Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new eol detection logic #96

Merged
merged 1 commit into from
Dec 10, 2019
Merged

feat: new eol detection logic #96

merged 1 commit into from
Dec 10, 2019

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Dec 10, 2019

Use detect-newline to detect EOL

Before, EOL is decided by first linebreak,

After,

Detect the dominant newline character of a string

I think it's more reasonable

@keithamus keithamus merged commit 425352e into keithamus:master Dec 10, 2019
@keithamus
Copy link
Owner

🎉 This PR is included in version 1.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fisker fisker deleted the refactor-eol-detection branch December 11, 2019 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisker @keithamus