Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keypress should not set the "touched" value #41

Closed
matthew-wilson-itv opened this issue May 20, 2020 · 1 comment
Closed

Keypress should not set the "touched" value #41

matthew-wilson-itv opened this issue May 20, 2020 · 1 comment

Comments

@matthew-wilson-itv
Copy link

I believe that the fix for issue #27 introduced an error.

Whenever the user types in the field, "touched" is set to true. This is not standard behaviour, as far as I can tell.

For example, https://angular.io/guide/form-validation says

  • When the user changes the value in the watched field, the control is marked as "dirty".
  • When the user blurs the form control element, the control is marked as "touched".

I think that onKeyUp should not be calling onTouchedCb.
kekeh added a commit that referenced this issue May 20, 2020
@kekeh
Fixed: Keypress should not set the touched value #41.
9603308
@kekeh
Copy link
Owner

kekeh commented May 20, 2020

Hi @matthew-wilson-itv

I fixed this. Try version 0.7.0.

@kekeh kekeh closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kekeh @matthew-wilson-itv