-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in Linux device enumeration #126
Comments
I think there is a second issue with the filtering of the DefactoStandardResolutions. The following lines don't seem to take operator precedence into account correctly. The modulo division has a higher order of precedence than the subtraction meaning it will happen before the subtraction. I think there should be parenthesis around the subtraction to ensure it occurs before the modulo division.
and
Currently I believe this will result in no characteristics being returned for devices that report a (specifically this issue along with #127 seems to be stopping my Raspberry PI onboard camera from being enumerated successfully) |
@gplwhite I will review it in a couple of days, just wait and see. |
Merged, thanks! |
Hello,
I think there are a couple of mistakes in the enumeration of devices on Linux. There appear to be two places where each DefactoryStandardResolution frame width is incorrectly compared to the enumerated frame max_height - instead of the frame max_width.
FlashCap/FlashCap.Core/Devices/V4L2Devices.cs
Line 66 in 854186a
and
FlashCap/FlashCap.Core/Devices/V4L2Devices.cs
Line 80 in 854186a
The text was updated successfully, but these errors were encountered: