-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support release group types #15
Comments
Thanks for your detailed thoughts, I agree with almost all of them. |
"Live" is also something that could be potentially be detected. I haven's seen live tracks explicitly marked as such in APIs, but in many cases you find a suffix like "(live)" on the track or even release titles. If the release has this or if all the tracks have it then it seems safe to set the live type. |
I'll look into this one |
Some platforms use "Single" (iTunes I think) for what's clearly "EP". Definitions of those are rather fuzzy but from my experience the most common cases are the following:
Some cases are tricky:
Number of tracks, duration of individual tracks, total duration, similar track titles give hints too. title 4:00 would be a single (+remix) but: titleA 4:00 more likely an EP. Of course, since definitions of single/EP/album are not very clear, we cannot be sure in all cases. Sometimes that's what's the annotation says: |
@zas I think because EP is so vague the best rule of thumb for EPs is to only use it if the band or label explicitly call it an EP. Otherwise it is more likely a single or album. I'm not sure whether Harmony really should set a type guessed from track count and length. IMHO it is better to not preset a type at all in those cases and have the user choose themselves. Maybe one way would be to use the track count / length as indicators, but only to unset the type if it does not seem to match.
Not sure about this rule, really. I have seen singles that had, two or even three extra tracks. Often one of thee tracks at least is some kind of variation (remix, instrumental version, orchestral version etc.) of the main track, but not always. Hence I think it is then more about presentation. If it is marketed as a single and e.g. is named after the single track on the cover, maybe with a sticker that it contains "bonus tracks" then I would go with single. If it has a name distinct from the individual song titles and more looks like a small album it probably is indeed an EP. |
Actually all definitions of "release group type" are rather "fuzzy", not only EP (https://musicbrainz.org/doc/Release_Group/Type). I agree, but we'll likely end with a lot of empty release group types. A typical case for me is when the title do not show "EP" on digital stores but it appears clearly on the cover art. Guessing "EP" based on durations/number of tracks works more often it doesn't.
That's not a "rule", but rather an observation, and I posted another example with same durations but different titles which is a single, so I agree with you. |
@kellnerd I do. I can also open a draft PR with what I have and have this for discussion and coordination with your work. Out of interest: Is the MB provider also considered the solution for finding existing MB releases, so the user can be notified that a release already exists? |
A draft PR would be nice to see, although I just realized that I will probably let the MB provider set the RG MBID rather than the RG types 😇
That's the idea, at least for the GTIN this should work without additional effort. |
Not sure there is any value of storing the ID with the There is an enum like type and type to ID mapping in your musicbrainz library anyway. So yes, you could use the ID in the MB provider implementation to map to the enum like type, but you can also just use the names directly. |
The first iteration of this feature is now live with v2024.7.8, thank you @phw!
I forgot to answer here, but I was talking about the release group MBID, not the MBID (or even the internal ID) of a release group primary/secondary type. The names of the types are also available in the API response, so I can use these if there should be any value in seeding the RG type names in addition to the RG MBID. |
Another type to detect fro titles might be remix. Release and track titles often follow the form "Song Title (some name remix)" or just "Song Title (remix)". Release titles also commonly have "(remixes)" or "(the someone remixes)" appended. Could be similar to live where this also applies as a type if all tracks are identified as remix. Remix in title: https://open.spotify.com/intl-de/album/6L9Z6gzQugGXIh8WdODMnI More examples: |
It would be good if providers could set the primary type and if this would be seeded when submitting to MB.
Not all providers will support this, but it is sometimes possible to at least detect singles and EPs. If in doubt a provider should likely keep this field empty.
Some notes on specific implementations:
- Single
and- EP
seem to be commonly added to singles / EPs. These should be stripped (see Remove- Single
&- EP
from release names automagically #9) and then can be used for seeding the primary type as well. a-tisket does this.album_type
, which is one ofalbum
,single
orcompilation
. Maybe it is too broad to use the album type (better leave it empty and have the user decide), but single and compilation should be fine to use.Generally it seems that if specific types, in particular single or EP, are detectable, this could be seeded. In most cases a source type of "album", if given, might be too unspecific and better kept out.
In the release editor the primary type can be seeded using the field
type
.The text was updated successfully, but these errors were encountered: