Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer type check has scoping issues #15

Open
palant opened this issue Aug 18, 2016 · 0 comments
Open

Buffer type check has scoping issues #15

palant opened this issue Aug 18, 2016 · 0 comments
Labels
bug patch-welcome

Comments

@palant
Copy link

palant commented Aug 18, 2016

I tried using this module and hit the "expected Uint8Array" exception. Problem seems to be that the caller is running in a sandbox (via vm module), so its Uint8Array class is coming from a different scope. It might be better to test for buf.BYTES_PER_ELEMENT == 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug patch-welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@palant @kenany