Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String literal indexes #28

Open
kenbot opened this issue Feb 28, 2017 · 2 comments
Open

String literal indexes #28

kenbot opened this issue Feb 28, 2017 · 2 comments

Comments

@kenbot
Copy link
Owner

kenbot commented Feb 28, 2017

Strings seem a common enough index type that a literal syntax could be useful, ie for JSON or XML documents. Single quotes will be the most convenient. I don't think there is any value in supporting double quotes as well.

@kenbot kenbot added this to the 1.1 milestone Feb 28, 2017
@kenbot
Copy link
Owner Author

kenbot commented Apr 22, 2017

This can and should be done, but it's a bit harder than it looks. The lexer & parser really need to be rewritten and combined into a proper monadic parser, instead of the hokey little Either-thing we have. The usual stream of lexed symbols can't be used, because the symbols might be meaningless text inside a string literal.

I suspect the resulting parser will still be small and tailored enough to justify keeping in the codebase; I am keen to avoid the dependency of a parser combinator library if I can help it.

@kenbot kenbot removed this from the 1.1 milestone May 17, 2017
@kenbot
Copy link
Owner Author

kenbot commented May 17, 2017

Descoping from 1.1; it will be a bit of work, and there are more important things to focus on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant