From 4c51d47269a2610db6fde2660aac9aad3e10b4e2 Mon Sep 17 00:00:00 2001 From: Tatsuyuki Ishi Date: Fri, 6 Apr 2018 16:23:53 +0900 Subject: [PATCH] bootstrap: Remove the fast path This is rarely noticed, but when you have old submodules, not updating them will cause you run into https://github.com/rust-lang/cargo/issues/4678. --- src/bootstrap/bootstrap.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/bootstrap/bootstrap.py b/src/bootstrap/bootstrap.py index cf54591f25cd5..487440becf630 100644 --- a/src/bootstrap/bootstrap.py +++ b/src/bootstrap/bootstrap.py @@ -770,10 +770,7 @@ def bootstrap(help_triggered): if 'dev' in data: build.set_dev_environment() - # No help text depends on submodules. This check saves ~1 minute of git commands, even if - # all the submodules are present and downloaded! - if not help_triggered: - build.update_submodules() + build.update_submodules() # Fetch/build the bootstrap build.build = args.build or build.build_triple()