Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assignment on pull_request_review action #68

Open
samkio opened this issue Apr 19, 2022 · 0 comments
Open

Allow assignment on pull_request_review action #68

samkio opened this issue Apr 19, 2022 · 0 comments

Comments

@samkio
Copy link

samkio commented Apr 19, 2022

Hi we are trying to set up this action such that when a PR is approved by a developer this action will auto-assign a QA engineer. The following is my GitHub action and auto-assign-action config. When this is used however the message Warning: Empty value for parameter 'pull_number': undefined is shown. I believe this is because we are using the pull_request_review action instead of pull_request or pull_request_target and so the PR number cannot be found. Is there a way to do this today or is a change required to add this functionality?

.github/auto_assign_qa.yml

addReviewers: true
addAssignees: false

reviewers:
  - samkio

numberOfReviewers: 0

.github/workflows/qa-assign.yml

name: "Auto assign QA reviewers"
on:
  pull_request_review:
    types: [submitted]
jobs:
  add-qa-reviewers:
    if: github.event.review.state == 'approved'
    runs-on: ubuntu-latest
    steps:
      - uses: actions-ecosystem/action-add-labels@v1
        with:
          labels: "ready for test"
      - uses: kentaro-m/auto-assign-action@v1.2.1
        with:
          configuration-path: ".github/auto_assign_qa.yml"

Log:

Run kentaro-m/auto-assign-action@v1.2.1
  with:
    configuration-path: .github/auto_assign_qa.yml
    repo-token: ***
Warning: Empty value for parameter 'pull_number': undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant