Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Connection String Support #53

Closed
netsy opened this issue Apr 8, 2024 · 2 comments
Closed

Add Connection String Support #53

netsy opened this issue Apr 8, 2024 · 2 comments

Comments

@netsy
Copy link

netsy commented Apr 8, 2024

Azure Application Insights will end support for instrumentation key on 2025. Auzre recommends transitioning to connection strings to take advantage of new capabilities.

I am studying a PR from OpenTelemetry to explore the possibility of adding support for connection strings in azure_application_insights. Do you have any insights on this matter?

@m-gug
Copy link
Contributor

m-gug commented Jul 18, 2024

@netsy I've also been wondering whether adjustments are needed here to switch to the connection string.
I've now looked at the official JS Application Insights SDK and it looks to me as if the connection string is only parsed and the InstrumentationKey contained in it is still in the transmitted events in 'iKey' (https://github.com/microsoft/ApplicationInsights-JS/blob/6ec22e829d568892bb005beefcc245471a7d788b/tools/applicationinsights-web-snippet/src/snippet.ts#L97).
Only the ingestion endpoint would also be parsed.

But we can already specify a different ingestion endpoint in the TransmissionProcessor, so I don't think any adjustments are necessary at the moment, or am I missing something?

@kentcb
Copy link
Owner

kentcb commented Oct 11, 2024

See #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants