Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allowed cypress v4 as a valid peer #119

Merged
merged 1 commit into from
Feb 6, 2020
Merged

feat: allowed cypress v4 as a valid peer #119

merged 1 commit into from
Feb 6, 2020

Conversation

travi
Copy link
Contributor

@travi travi commented Feb 6, 2020

closes #118

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@NicholasBoll
Copy link
Contributor

@travi Could you also update devDependencies to ^4.0.0? If the CI tests pass, I think this library can officially support Cypress@2,3,4

@travi
Copy link
Contributor Author

travi commented Feb 6, 2020

sure thing

@travi
Copy link
Contributor Author

travi commented Feb 6, 2020

updated

NicholasBoll
NicholasBoll approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@NicholasBoll NicholasBoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 👍

@NicholasBoll NicholasBoll changed the title fix: allowed cypress v4 as a valid peer feat: allowed cypress v4 as a valid peer Feb 6, 2020
@NicholasBoll NicholasBoll merged commit e052ece into testing-library:master Feb 6, 2020
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@NicholasBoll
Copy link
Contributor

@all-contributors please add @travi for code

@allcontributors allcontributors bot mentioned this pull request Feb 6, 2020
Merged
@allcontributors
Copy link
Contributor

@NicholasBoll

I've put up a pull request to add @travi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasBoll NicholasBoll NicholasBoll approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support for cypress v4
3 participants
@travi @NicholasBoll @kentcdodds