fix: allow cypress@5 as peer dependency #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkappeler
approved these changes
Aug 21, 2020
|
What's the warning? Should we merge despite it or wait? |
|
I'm assuming they meant that using v5 worked fine except for the peer dependency warning which this pr will fix |
|
Exactly |
|
Sorry, I didn't notice this PR and I updated it without triggering a release. I'll push one out now. Sorry I missed the PR. |
kentcdodds
added a commit
that referenced
this pull request
Aug 21, 2020
|
No problem at all 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Up peer dep to the fresh v5 release
Why:
To avoid a warning when installing
How:
GitHub UI
Checklist:
Worked fine except for the warning locally 👍