Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing library command timeouts doesn't register with the timeout-bar in the Cypress test-runner #217

Closed
Svish opened this issue Mar 16, 2022 · 2 comments · Fixed by #240 · May be fixed by turnmodz/suquinnff#22 or turnmodz/suquinnff#23
Labels

Comments

@Svish
Copy link

Svish commented Mar 16, 2022

  • cypress-testing-library version: 8.0.2
  • node version: 14.17.0
  • npm (or yarn) version: 6.14.13

What you did:

Added a timeout to findByRole, like this:

    cy.findByRole('button', {
      name: 'Not existing',
      timeout: 120_000,
    }).click();

What happened:

The timeout-bar of running/waiting testing-library commands in the Cypress test-runner finishes way before 120 seconds are up. Looks to take around 10 seconds for it to finish? This is the progress-bar I'm talking about:

image

If I use timeout on regular cypress commands, like cy.get('foobar', { timeout: 120_000 }), then the timeout-bar works correctly and does take 120 seconds to pass.

Problem description:

The timeout-option of testing-library commands doesn't seem to register correctly with the timeout-bar in the Cypress test-runner, like other commands do.

Suggested solution:

Timeout option on testing-library commands, should work and display the same as for other commands in the Cypress test-runner.

@JavierMartinz
Copy link

Any workaround for this? I'm also experiencing this issue.

@github-actions
Copy link

🎉 This issue has been resolved in version 8.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment