Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update error stack traces for Cypress #239

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

NicholasBoll
Copy link
Contributor

Fixes #232

Update the Cypress error message rather than the entire error object. This merges the useful message of DOM Testing Library with the useful context of the Cypress error. This allows Cypress to find the line number of the failure in spec files instead of deep inside DOM Testing Library.

Fixes #232

Update the Cypress error message rather than the entire error object. This merges the useful message of DOM Testing Library with the useful context of the Cypress error. This allows Cypress to find the line number of the failure in spec files i
nstead of deep inside DOM Testing Library.
@NicholasBoll NicholasBoll merged commit e9fdfae into main Nov 15, 2022
@NicholasBoll NicholasBoll deleted the fix/error-stack-trace branch November 15, 2022 19:27
@github-actions
Copy link

🎉 This PR is included in version 8.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cypress cannot find the line number of failed .findBy commands
1 participant