Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

chore: Enable skaffold to build and deploy initcontainer #139

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

christian-kreuzberger-dtx
Copy link
Contributor

@christian-kreuzberger-dtx christian-kreuzberger-dtx commented Dec 29, 2021

This PR

  • enables skaffold to also build and deploy the initcontainer
  • added a rollme annotation to the deployment of job-executor-service such that it always restarts, even when just helm values are updated (and not the Kubernetes image itself)
  • Update Dockerfile and initcontainer.Dockerfile to look the same

Proof

skaffold run --tail

image

keptn trigger delivery ...

image

image

Signed-off-by: Christian Kreuzberger <christian.kreuzberger@dynatrace.com>
@github-actions
Copy link
Contributor

The following Docker Images have been built:

  • keptncontrib/job-executor-service:0.1.5-dev-PR-139,keptncontrib/job-executor-service:0.1.5-dev-PR-139.202112291425
  • keptncontrib/job-executor-service-initcontainer:0.1.5-dev-PR-139,keptncontrib/job-executor-service-initcontainer:0.1.5-dev-PR-139.202112291425

Copy link
Contributor

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-kreuzberger-dtx christian-kreuzberger-dtx deleted the patch/skaffold_run branch January 11, 2022 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants