Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

feat: Utilize gitCommitID from cloud events to fetch resources #303

Merged
merged 9 commits into from
Jul 8, 2022
Merged

feat: Utilize gitCommitID from cloud events to fetch resources #303

merged 9 commits into from
Jul 8, 2022

Conversation

Raffy23
Copy link
Member

@Raffy23 Raffy23 commented Jul 5, 2022

This PR

  • utilizes the gitcommitID query parameter when fetching resource files

@Raffy23
feat: Utilize gitCommitID from cloud events to fetch resources
da62092 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
refactor: Add auto-generated gomock files
312cdfa 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
refactor: Limit new integration test to version >= 0.16.0
322aa2a 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
github-actions[bot]
github-actions bot reviewed Jul 5, 2022
View reviewed changes
pkg/config/reader.go Outdated Show resolved Hide resolved
pkg/config/reader.go Outdated Show resolved Hide resolved
pkg/eventhandler/eventhandlers.go Outdated Show resolved Hide resolved
pkg/eventhandler/eventhandlers.go Outdated Show resolved Hide resolved
pkg/eventhandler/eventhandlers.go Show resolved Hide resolved
pkg/keptn/config_service_test.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service.go Outdated Show resolved Hide resolved
pkg/keptn/resource_service.go Outdated Show resolved Hide resolved
test/e2e/gitcommitid_test.go Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022 •
edited
Loading

Unit Test Results

123 tests   112 ✔️  2s ⏱️
  13 suites    11 💤
    1 files        0 ❌

Results for commit 1230ea6.

♻️ This comment has been updated with latest results.

@Raffy23
fix: Integrations tests for >= 0.16.0
0574957 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23 Raffy23 force-pushed the feat/git-commitId branch 2 times, most recently from 69a8a3a to ac1f009 Compare July 5, 2022 14:04
@Raffy23
refactor: Apply suggestions from reviewdog
2e176c4 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
refactor: Remove debugging output
63b97c7 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
refactor: Fix unit tests
882ced0 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23
refactor: Remove debug output
e90954b 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@Raffy23 Raffy23 marked this pull request as ready for review July 6, 2022 06:45
@Raffy23
refactor: Remove old workaround for url.QueryEscape
1230ea6 
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

The following Docker Images have been built:

  • keptncontrib/job-executor-service:0.2.4-dev-PR-303,keptncontrib/job-executor-service:0.2.4-dev-PR-303.202207060742
  • keptncontrib/job-executor-service-initcontainer:0.2.4-dev-PR-303,keptncontrib/job-executor-service-initcontainer:0.2.4-dev-PR-303.202207060742

christian-kreuzberger-dtx
christian-kreuzberger-dtx approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raffy23 Raffy23 merged commit 5187bd9 into main Jul 8, 2022
@Raffy23 Raffy23 deleted the feat/git-commitId branch July 8, 2022 08:01
TannerGabriel pushed a commit that referenced this pull request Jul 12, 2022
@Raffy23 @TannerGabriel
feat: Utilize gitCommitID from cloud events to fetch resources (#303)
d7238c4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions GitHub Actions github-actions left review comments

@christian-kreuzberger-dtx christian-kreuzberger-dtx christian-kreuzberger-dtx approved these changes

@pchila pchila Awaiting requested review from pchila

@TannerGabriel TannerGabriel Awaiting requested review from TannerGabriel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Raffy23 @christian-kreuzberger-dtx