Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

feat: Add Keptn dev version to integration tests #314

Merged
merged 4 commits into from
Jul 18, 2022
Merged

feat: Add Keptn dev version to integration tests #314

merged 4 commits into from
Jul 18, 2022

Conversation

TannerGabriel
Copy link
Member

@TannerGabriel TannerGabriel commented Jul 11, 2022 •
edited
Loading

This PR

  • Fetches the latest Keptn release and prerelease
  • Adds the versions to the Github action matrix
  • Checks if the Keptn chart is available in the default Helm repository (https://charts.keptn.sh). If not, https://charts-dev.keptn.sh is used instead.

Integration Tests: https://github.com/keptn-contrib/job-executor-service/actions/runs/2649231941

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022 •
edited
Loading

Unit Test Results

125 tests   113 ✔️  2s ⏱️
  13 suites    12 💤
    1 files        0 ❌

Results for commit 2c9d2f0.

♻️ This comment has been updated with latest results.

@TannerGabriel TannerGabriel marked this pull request as ready for review July 12, 2022 06:11
@TannerGabriel TannerGabriel force-pushed the feat/integration-test-keptn-dev-version branch from 6edf791 to c4e4951 Compare July 12, 2022 07:30
@TannerGabriel
feat: Add Keptn dev version to Integration tests
342c113 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel TannerGabriel force-pushed the feat/integration-test-keptn-dev-version branch from 495c035 to 342c113 Compare July 12, 2022 07:40
@TannerGabriel
Sort before picking release version
fac35db 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Change Helm repo validation
7232450 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
christian-kreuzberger-dtx
christian-kreuzberger-dtx reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach done here! Before we merge, let's addresses the comments, i.e., make sure that we have a new release of keptn/gh-automation.

@TannerGabriel
Use specific actions version + Change action name
2c9d2f0 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@github-actions
Copy link
Contributor

The following Docker Images have been built:

  • keptncontrib/job-executor-service:0.2.4-dev-PR-314,keptncontrib/job-executor-service:0.2.4-dev-PR-314.202207180606
  • keptncontrib/job-executor-service-initcontainer:0.2.4-dev-PR-314,keptncontrib/job-executor-service-initcontainer:0.2.4-dev-PR-314.202207180606

pchila
pchila approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TannerGabriel TannerGabriel merged commit db5686a into main Jul 18, 2022
@TannerGabriel TannerGabriel deleted the feat/integration-test-keptn-dev-version branch July 18, 2022 07:16
@christian-kreuzberger-dtx christian-kreuzberger-dtx mentioned this pull request Jul 20, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pchila pchila pchila approved these changes

@Raffy23 Raffy23 Awaiting requested review from Raffy23

@christian-kreuzberger-dtx christian-kreuzberger-dtx Awaiting requested review from christian-kreuzberger-dtx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TannerGabriel @Raffy23 @christian-kreuzberger-dtx @pchila