Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

feat: Add global and stage job configuration lookup #338

Merged
merged 5 commits into from
Aug 3, 2022

Conversation

Raffy23
Copy link
Member

@Raffy23 Raffy23 commented Aug 3, 2022

This PR

Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Test Results

137 tests   125 ✔️  2s ⏱️
  13 suites    12 💤
    1 files        0

Results for commit 6184dfb.

♻️ This comment has been updated with latest results.

Copy link
Member

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some typos I found looking over the PR.

docs/FEATURES.md Outdated Show resolved Hide resolved
docs/FEATURES.md Outdated Show resolved Hide resolved
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
Copy link
Contributor

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some duplicated code between keptn/resource_service.go and keptn/config_service.go, but that is to be expected and not part of this PR to be fixed.
I will create a follow-up story for that.

Other then that, LGTM

Copy link
Member

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some small improvement ideas that are optional.

pkg/keptn/resource_service.go Show resolved Hide resolved
pkg/keptn/resource_service.go Show resolved Hide resolved
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
This reverts commit 56ffa12.

Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
Copy link
Member

@TannerGabriel TannerGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

The following Docker Images have been built:

  • keptncontrib/job-executor-service:0.2.4-dev-PR-338,keptncontrib/job-executor-service:0.2.4-dev-PR-338.202208031209
  • keptncontrib/job-executor-service-initcontainer:0.2.4-dev-PR-338,keptncontrib/job-executor-service-initcontainer:0.2.4-dev-PR-338.202208031209

@Raffy23 Raffy23 merged commit c146449 into main Aug 3, 2022
@Raffy23 Raffy23 deleted the feat/global-configuration branch August 3, 2022 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using a project-wide job/config.yaml (e.g., from main/master branch)
3 participants