-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Add global and stage job configuration lookup #338
Conversation
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some typos I found looking over the PR.
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some duplicated code between keptn/resource_service.go and keptn/config_service.go, but that is to be expected and not part of this PR to be fixed.
I will create a follow-up story for that.
Other then that, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some small improvement ideas that are optional.
Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
This reverts commit 56ffa12. Signed-off-by: Raphael Ludwig <raphael.ludwig@dynatrace.com>
3831095
to
6184dfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following Docker Images have been built:
|
This PR
job/config.yaml
(e.g., from main/master branch) #145