Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

feat: Send error cloud event #354

Merged
merged 6 commits into from
Sep 5, 2022
Merged

feat: Send error cloud event #354

merged 6 commits into from
Sep 5, 2022

Conversation

TannerGabriel
Copy link
Member

This PR

  • Reimplement ErrorLogSender with go-sdk
  • Send error event when job/config.yaml cannot be found

@TannerGabriel
feat: Send error cloud event
66acc72 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022 •
edited
Loading

Test Results

130 tests   118 ✔️  2s ⏱️
  13 suites    12 💤
    1 files        0 ❌

Results for commit f93167e.

♻️ This comment has been updated with latest results.

@TannerGabriel
Send error log using logs api instead of cloud event
747ed2f 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Rewrite unit tests to use log instead of cloud event
5d4158d 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Add comment to exported type
de50801 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel TannerGabriel marked this pull request as ready for review September 5, 2022 06:51
Raffy23
Raffy23 reviewed Sep 5, 2022
View reviewed changes
pkg/keptn/errorlog.go Outdated Show resolved Hide resolved
@TannerGabriel
Change function declaration
c5ecffe 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@TannerGabriel
Fix function return type
f93167e 
Signed-off-by: TannerGabriel <gabrieltanner.code@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

The following Docker Images have been built:

  • keptncontrib/job-executor-service:0.2.6-dev-PR-354,keptncontrib/job-executor-service:0.2.6-dev-PR-354.202209050711
  • keptncontrib/job-executor-service-initcontainer:0.2.6-dev-PR-354,keptncontrib/job-executor-service-initcontainer:0.2.6-dev-PR-354.202209050711

Raffy23
Raffy23 approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@Raffy23 Raffy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TannerGabriel TannerGabriel merged commit e247419 into main Sep 5, 2022
@TannerGabriel TannerGabriel deleted the feat/send-error-log branch September 5, 2022 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Raffy23 Raffy23 Raffy23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TannerGabriel @Raffy23