Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use custom k8s label to inject certificates where needed #1288

Merged
merged 8 commits into from
Apr 27, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Apr 26, 2023

This PR

  • fixes the helm chart by removing duplicate part-of labels
  • adds a new custom label that is used to inject certificates into k8s resources through certificate-operator
  • makes the new custom label configurable through the helm values
  • makes already existing k8s part-of labels consistent

Fixes #1287

@mowies mowies requested a review from a team as a code owner April 26, 2023 13:20
@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit d9b6ec6
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6449253ae56ac40008c7442a
😎 Deploy Preview https://deploy-preview-1288--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1288 (db65453) into main (b5f4e91) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1288   +/-   ##
=======================================
  Coverage   59.83%   59.83%           
=======================================
  Files         138      138           
  Lines       10462    10462           
=======================================
  Hits         6260     6260           
  Misses       3967     3967           
  Partials      235      235           
Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 60.45% <ø> (ø)
lifecycle-operator 78.34% <ø> (ø)
metrics-operator 77.80% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added the ops label Apr 26, 2023
bacherfl
bacherfl previously approved these changes Apr 27, 2023
odubajDT
odubajDT previously approved these changes Apr 27, 2023
@mowies mowies marked this pull request as draft April 27, 2023 09:18
@mowies mowies dismissed stale reviews from odubajDT and bacherfl via 57b1038 April 27, 2023 09:49
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
…abels

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
…ator to generate a cert for

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies marked this pull request as ready for review April 27, 2023 10:40
@mowies mowies merged commit 8fe5df3 into keptn:main Apr 27, 2023
@mowies mowies deleted the fix-helm-labels branch April 27, 2023 11:10
@keptn-bot keptn-bot mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cert-manager documentation Improvements or additions to documentation helm metrics-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix duplicate helm chart labels for deployment in klt
5 participants