Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt KLT mutating webhook to support ReadinessGates #1459

Closed
3 tasks
Tracked by #1448
thisthat opened this issue May 24, 2023 · 1 comment
Closed
3 tasks
Tracked by #1448

Adapt KLT mutating webhook to support ReadinessGates #1459

thisthat opened this issue May 24, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers lifecycle-operator on hold Do not merge yet
Milestone

Comments

@thisthat
Copy link
Member

thisthat commented May 24, 2023

Goal

Change the mutating webhook to remove the addition of the KLT scheduler if the FF klt.readiness-gate is true

Details

If the FF klt.readiness-gate is true, KLT relies on readiness gate APIs to block deployments to proceed. Hence, we don't need to mutate manifests by adding our scheduler plugin.

DoD

  • If klt.readiness-gate is false, the webhook behaves like the past
  • If klt.readiness-gate is true, the webhook doesn't add the scheduler
  • Kuttl tests

Dependency

@thisthat thisthat changed the title Refactor KLT mutating webhooks (WIP) Refactor KLT mutating webhooks May 25, 2023
@thisthat thisthat changed the title (WIP) Refactor KLT mutating webhooks (WIP) Adapt KLT mutating webhook May 26, 2023
@thisthat thisthat added enhancement New feature or request status: ready-for-refinement Issue is relevant for the next backlog refinment operator labels May 26, 2023
@thisthat thisthat added this to the 0.9 milestone May 26, 2023
@thisthat thisthat changed the title (WIP) Adapt KLT mutating webhook Adapt KLT mutating webhook May 26, 2023
@thisthat thisthat added good first issue Good for newcomers and removed status: ready-for-refinement Issue is relevant for the next backlog refinment labels Jun 13, 2023
@RealAnna RealAnna added the on hold Do not merge yet label Jul 12, 2023
@thisthat thisthat modified the milestones: 0.9, 0.10 Sep 25, 2023
@thisthat thisthat changed the title Adapt KLT mutating webhook Adapt KLT mutating webhook to support ReadinessGates Sep 25, 2023
@thisthat thisthat modified the milestones: 0.10, 0.9 Sep 26, 2023
@odubajDT
Copy link
Contributor

This functionality is already in place, closing this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers lifecycle-operator on hold Do not merge yet
Projects
Archived in project
Development

No branches or pull requests

3 participants