Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): Introduce KeptnEvaluation Controller + CRD #168

Merged
merged 29 commits into from
Oct 18, 2022
Merged

feat(operator): Introduce KeptnEvaluation Controller + CRD #168

merged 29 commits into from
Oct 18, 2022

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Oct 14, 2022 •
edited by RealAnna
Loading

Signed-off-by: odubajDT ondrej.dubaj@dynatrace.com

This PR introduces the controller for KeptnEvaluations, to test it :

cd operator/config/samples
 kubectl apply -f lifecycle_v1alpha1_keptnevaluationprovider.yaml 
 kubectl apply -f lifecycle_v1alpha1_keptnevaluationdefinition.yaml 
 kubectl apply -f lifecycle_v1alpha1_keptnevaluation.yaml

image

Resolves: #161

Notes: what to do with prometheus query and Timeframes should be defined in the PR for #163

Type, FailAction and RetryInterval are also currently unused and in there for later PR

@odubajDT odubajDT mentioned this pull request Oct 14, 2022
Closed
@RealAnna RealAnna marked this pull request as ready for review October 14, 2022 12:10
@thschue thschue added the on hold Do not merge yet label Oct 17, 2022
This was referenced Oct 17, 2022
Closed
Closed
thschue
thschue requested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the webhook in a way that annotations or labels could be used

operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/common/common.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/common/phases.go Outdated Show resolved Hide resolved
operator/webhooks/pod_mutating_webhook.go Outdated Show resolved Hide resolved
@thschue thschue removed the on hold Do not merge yet label Oct 18, 2022
odubajDT and others added 19 commits October 18, 2022 09:45
@odubajDT @RealAnna
feat(operator): Introduce KeptnEvaluation Controller + CRD
54db85f 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @RealAnna
additional fields to CRD
f4fa0e2 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @RealAnna
controller in separate dir
108affc 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @RealAnna
prepare structures
0ba247f 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @RealAnna
set up everything except logic
31560fe 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @RealAnna
first draft without evaluation logic
7e18a8a 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@RealAnna
chore: init evaluation status
1c627ca 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: note TODOS
798adf8 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: fixed namespaced resources
a15569e 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: fixed queryEvaluation to always return false for now
c1052fd 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: added rebac and generated resources
363c2a6 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: added rebac and generated resources
c99d8fc 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
chore: fixed copypasta
c609780 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
feat: added few events ordered controller
03ad539 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
feat: added few events ordered controller
2d42716 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@odubajDT @RealAnna
implement timeFrame and retryCount functionality
3884cb4 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @RealAnna
polish duration
c928f1b 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@RealAnna
feat: added print app version and status
c194d39 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
feat: added default timeframe
9dea1c5 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
RealAnna and others added 10 commits October 18, 2022 09:45
@RealAnna
feat: added default timeframe
4600961 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
feat: added default timeframe
fe030eb 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
feat: added default timeframe
fff6e4d 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
feat: added default timeframe
4fc2322 
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
feat: added endtime in case of failure, change status to map in evalu…
6b5adf3 
…ation

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
feat: added endtime in case of failure, change status to map in evalu…
a3672f5 
…ation

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna
feat: added endtime in case of failure, change status to map in evalu…
5c79b6d 
…ation

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@odubajDT @RealAnna
rename analysis to evaluation
72952cc 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @RealAnna
go mod tidy
1da4179 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @RealAnna
make generate
ea4a33e 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@RealAnna RealAnna requested a review from thschue October 18, 2022 07:55
thschue
thschue approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bacherfl bacherfl merged commit 1ce044a into keptn:main Oct 18, 2022
@github-actions github-actions bot mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl approved these changes

@thschue thschue thschue approved these changes

@thisthat thisthat Awaiting requested review from thisthat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap KeptnEvaluation Controller
4 participants
@odubajDT @bacherfl @thschue @RealAnna