Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update kustomization.yaml to avoid usage of deprecated patches/configs #2004

Merged
merged 10 commits into from
Sep 18, 2023

Conversation

prakrit55
Copy link
Member

Closes #1775

Updated kustomiztion.yaml in configs

Signed-off-by: Griffin <prakritimandal611@gmail.com>
@netlify
Copy link

netlify bot commented Sep 3, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c2ae195
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64f4ab95e3574f00089cc228
😎 Deploy Preview https://deploy-preview-2004--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prakrit55 prakrit55 changed the title fix: Update kustomization.yaml to avoid usage of deprecated patches/configs fix: update kustomization.yaml to avoid usage of deprecated patches/configs Sep 3, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2004 (725fbcb) into main (017e08b) will increase coverage by 0.00%.
Report is 70 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2004   +/-   ##
=======================================
  Coverage   84.17%   84.18%           
=======================================
  Files         149      150    +1     
  Lines        9531     9597   +66     
=======================================
+ Hits         8023     8079   +56     
- Misses       1222     1229    +7     
- Partials      286      289    +3     

see 10 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 57.86% <ø> (-1.49%) ⬇️
lifecycle-operator 84.94% <ø> (+0.01%) ⬆️
metrics-operator 86.10% <ø> (+0.24%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

fix yamllint

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix yamllint

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix yamllint

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix yamllint

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fix yamllint

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
@prakrit55
Copy link
Member Author

hey @RealAnna, fixed the yamllint error, re-run can be triggered again.

add commented webhook patches in patches 

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
removed space

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
add commented lines in patches

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
configured the commented patches

Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution! :)

@odubajDT odubajDT merged commit 8d70fac into keptn:main Sep 18, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update kustomization.yaml to avoid usage of deprecated patches/configs
3 participants