Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(metrics-operator): usage of SLI and SLO converters #2013

Merged
merged 10 commits into from
Sep 11, 2023
Merged

docs(metrics-operator): usage of SLI and SLO converters #2013

merged 10 commits into from
Sep 11, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Sep 4, 2023 •
edited

Fixes: #2002

Depends on #2023

@github-actions github-actions bot added documentation Improvements or additions to documentation ops metrics-operator labels Sep 4, 2023
@netlify
Copy link

netlify bot commented Sep 4, 2023 •
edited

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit c1b9cf3
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64f98f51c6714b0008308aa5
😎 Deploy Preview https://deploy-preview-2013--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@odubajDT odubajDT added the on hold Do not merge yet label Sep 4, 2023
@github-actions github-actions bot removed on hold Do not merge yet ops labels Sep 4, 2023
@odubajDT odubajDT changed the title docs(metrics-operator): SLI and SLO converters doc(metrics-operator): SLI and SLO converters Sep 4, 2023
@odubajDT
Copy link
Contributor Author

odubajDT commented Sep 4, 2023 •
edited

Putting this on hold, as to finish the documentation, we need to reference a released image of metrics-operator containing this feature
#1832

@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited

Codecov Report

Merging #2013 (c1b9cf3) into main (83b34c8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2013   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files         150      150           
  Lines        9597     9597           
=======================================
  Hits         8062     8062           
  Misses       1245     1245           
  Partials      290      290
Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.06% <ø> (-1.38%) ⬇️
lifecycle-operator 84.94% <ø> (ø)
metrics-operator 85.43% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT changed the title doc(metrics-operator): SLI and SLO converters docs: SLI and SLO converters Sep 4, 2023
@odubajDT odubajDT changed the title docs: SLI and SLO converters docs(metrics-operator): usage of SLI and SLO converters Sep 4, 2023
@mowies mowies added the on hold Do not merge yet label Sep 4, 2023
thisthat
thisthat reviewed Sep 5, 2023
View reviewed changes
metrics-operator/converter/sli_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/sli_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/sli_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Outdated Show resolved Hide resolved
@odubajDT odubajDT marked this pull request as ready for review September 6, 2023 06:26
@odubajDT odubajDT requested a review from a team as a code owner September 6, 2023 06:26
@odubajDT odubajDT removed the on hold Do not merge yet label Sep 7, 2023
thisthat
thisthat reviewed Sep 7, 2023
View reviewed changes
metrics-operator/converter/sli_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/sli_converter.md Show resolved Hide resolved
metrics-operator/converter/sli_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Outdated Show resolved Hide resolved
metrics-operator/converter/slo_converter.md Outdated Show resolved Hide resolved
@odubajDT
docs(metrics-operator): SLI and SLO converters
9b66cba 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix linter + examples
fb83984 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix linter
0e57d84 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
split to 2 files
00b7916 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
PR review
e2f593f 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
pr review
c3f58e4 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
adapt names of parameters
ec96a92 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix release version
8e13ef8 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
pr review
22e45e8 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
add converter docs files into release-please conf
c1b9cf3 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 57bc225 into keptn:main Sep 11, 2023
36 checks passed
This was referenced Sep 11, 2023
Merged
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies left review comments

@thisthat thisthat thisthat approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation metrics-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document SLI and SLO converters
4 participants
@odubajDT @thisthat @bacherfl @mowies