Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve getting started guide #2058

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

mowies
Copy link
Member

@mowies mowies commented Sep 7, 2023

This PR

  • removes the rollout restart commands since they are not needed
  • fixes the klt tag version for the examples files
  • fixes the service name in the prometheus helm values
  • fixes release-please not updating the tag in the examples urls

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies requested review from a team as code owners September 7, 2023 11:47
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit df6ccdd
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64f9b869a8f2db0008cb1247
😎 Deploy Preview https://deploy-preview-2058--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thisthat thisthat changed the title docs: fix things in getting started guide docs: improve getting started guide Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2058 (df6ccdd) into main (83b34c8) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2058      +/-   ##
==========================================
+ Coverage   84.00%   84.08%   +0.08%     
==========================================
  Files         150      150              
  Lines        9597     9597              
==========================================
+ Hits         8062     8070       +8     
+ Misses       1245     1239       -6     
+ Partials      290      288       -2     

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.17% <ø> (-0.28%) ⬇️
lifecycle-operator 84.94% <ø> (ø)
metrics-operator 85.43% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies merged commit a6e4d65 into main Sep 7, 2023
38 of 39 checks passed
@mowies mowies deleted the fix-getting-started-guide branch September 7, 2023 12:12
mowies added a commit that referenced this pull request Sep 7, 2023
(cherry picked from commit a6e4d65)
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants