-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adapt Makefile command to run unit tests #2072
Conversation
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
===========================================
- Coverage 83.98% 59.14% -24.84%
===========================================
Files 150 35 -115
Lines 9597 2389 -7208
===========================================
- Hits 8060 1413 -6647
+ Misses 1246 836 -410
+ Partials 291 140 -151 see 127 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
0f323df
to
fa6a435
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not introduce this change since they could be anything and not necessary just unit tests. At the end, the current entry is a wrapper around go test
, hence make test
is a better name imho.
If you'd like to have a "run local tests before creating a PR", I'd rather have a new Makefile entry in the root Makefile with a unit-test
step that calls all the test
entrypoint in the respective sub-folders.
I would argue here. Currently
This for me makes logical sense. About the second though of introducing a |
Also OFO does use unit-test https://github.com/open-feature/open-feature-operator/blob/main/Makefile and same goes for prometheus operator where test calls all tests including unit-tests https://github.com/prometheus-operator/prometheus-operator/blob/main/Makefile#L338 |
No description provided.