fix(metrics-operator): fix panic due to write attempt on closed channel #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
…nish or time out in case of provider error Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
==========================================
+ Coverage 83.55% 84.42% +0.87%
==========================================
Files 108 151 +43
Lines 7071 9592 +2521
==========================================
+ Hits 5908 8098 +2190
- Misses 956 1210 +254
- Partials 207 284 +77
... and 42 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
commented
Sep 18, 2023
bacherfl
commented
Sep 18, 2023
bacherfl
commented
Sep 18, 2023
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
odubajDT
previously approved these changes
Sep 18, 2023
odubajDT
reviewed
Sep 18, 2023
test/integration/analysis-controller-multiple-providers/install.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
odubajDT
reviewed
Sep 19, 2023
test/integration/analysis-controller-multiple-providers/install.yaml
Outdated
Show resolved
Hide resolved
odubajDT
reviewed
Sep 19, 2023
test/integration/analysis-controller-multiple-providers/install.yaml
Outdated
Show resolved
Hide resolved
test/integration/analysis-controller-multiple-providers/install.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Sep 19, 2023
This was referenced Sep 19, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2104
This PR also adds a timeout of 10s to the worker pool responsible for gathering the analysis values, and changes the behavior of the pool to let all workers finish their job (or time out), in case there was an error during the retrieval of one value.