-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics-operator): fix panic due to write attempt on closed channel #2119
Conversation
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
…nish or time out in case of provider error Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
==========================================
+ Coverage 83.55% 84.42% +0.87%
==========================================
Files 108 151 +43
Lines 7071 9592 +2521
==========================================
+ Hits 5908 8098 +2190
- Misses 956 1210 +254
- Partials 207 284 +77
... and 42 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
test/integration/analysis-controller-multiple-providers/install.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
test/integration/analysis-controller-multiple-providers/install.yaml
Outdated
Show resolved
Hide resolved
test/integration/analysis-controller-multiple-providers/install.yaml
Outdated
Show resolved
Hide resolved
test/integration/analysis-controller-multiple-providers/install.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😻
Closes #2104
This PR also adds a timeout of 10s to the worker pool responsible for gathering the analysis values, and changes the behavior of the pool to let all workers finish their job (or time out), in case there was an error during the retrieval of one value.