Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add KeptnTaskDefinition tutorial #2121

Merged
merged 15 commits into from
Sep 29, 2023

Conversation

agardnerIT
Copy link
Contributor

@agardnerIT agardnerIT commented Sep 18, 2023

This PR:

  • Expands the "tutorial series" beyond "getting started"

After the getting started guide, Keptn users will have DORA metrics and this is the next logical step - implementing KeptnTasks.

This tutorial demonstrates how to add post tasks.

Out of scope

  • Do not explain app level tasks on this page - that's out of scope
  • Evaluations will form the next step in the tutorial series - evalautions are out of scope for this page as they require a thorough explanation of the metrics server

Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 18, 2023
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit fd0258f
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/651690564a1d4b000751c3e5
😎 Deploy Preview https://deploy-preview-2121--keptn-lifecycle-toolkit.netlify.app/docs/tutorials/add-tasks
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@agardnerIT
Copy link
Contributor Author

@aepfli why is this PR title invalid? Why can't it start with an uppercase letter?

Error: The subject "KeptnTaskDefinition tutorial" found in the pull request title "docs: KeptnTaskDefinition tutorial"
didn't match the configured pattern. Please ensure that the subject
doesn't start with an uppercase character.

Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@aepfli
Copy link
Member

aepfli commented Sep 19, 2023

@aepfli why is this PR title invalid? Why can't it start with an uppercase letter?

Error: The subject "KeptnTaskDefinition tutorial" found in the pull request title "docs: KeptnTaskDefinition tutorial"
didn't match the configured pattern. Please ensure that the subject
doesn't start with an uppercase character.

That is in fact something I stumbled upon regularly too, and it has to be done with the conventional commit setup.

@mowies maybe has some more insights, as this has been active on keptn before I contributed.

Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@agardnerIT agardnerIT changed the title docs: KeptnTaskDefinition tutorial docs: add KeptnTaskDefinition tutorial Sep 24, 2023
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
@agardnerIT agardnerIT marked this pull request as ready for review September 24, 2023 06:46
@agardnerIT agardnerIT requested review from a team as code owners September 24, 2023 06:46
Signed-off-by: Adam Gardner <26523841+agardnerIT@users.noreply.github.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RealAnna RealAnna merged commit de2604f into keptn:main Sep 29, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants