-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics-operator): flush status when analysis is finished #2122
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
===========================================
- Coverage 84.26% 54.26% -30.00%
===========================================
Files 150 22 -128
Lines 9597 1699 -7898
===========================================
- Hits 8087 922 -7165
+ Misses 1223 691 -532
+ Partials 287 86 -201 see 141 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
It never fails to surprise me how Codecov can claim there are coverage changes in the lifecycle operator in a PR where only the metrics operator is touched -,- |
test/integration/analysis-controller-existing-status/install.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with one optional suggestion
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
815038c
to
c1d8972
Compare
Kudos, SonarCloud Quality Gate passed!
|
closes #2093