Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adapt KeptnTask example to changes in API #2124

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

bacherfl
Copy link
Member

Closes #2120

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 18, 2023
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 858c5b6
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65083314afe91a0008599e68
😎 Deploy Preview https://deploy-preview-2124--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bacherfl bacherfl marked this pull request as ready for review September 18, 2023 11:26
@bacherfl bacherfl requested review from a team as code owners September 18, 2023 11:26
agardnerIT
agardnerIT previously approved these changes Sep 19, 2023
Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2124 (1ab3599) into main (d08df40) will increase coverage by 26.15%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2124       +/-   ##
===========================================
+ Coverage   58.26%   84.41%   +26.15%     
===========================================
  Files          35      151      +116     
  Lines        2389     9601     +7212     
===========================================
+ Hits         1392     8105     +6713     
- Misses        859     1213      +354     
- Partials      138      283      +145     

see 130 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.37% <ø> (+1.51%) ⬆️
lifecycle-operator 84.94% <ø> (?)
metrics-operator 86.56% <ø> (?)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl merged commit bcc64e8 into keptn:main Sep 19, 2023
38 checks passed
@bacherfl bacherfl deleted the fix/doc-keptn-task branch September 19, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: v1alpha3 has changed so Keptn on non-k8s tutorial fails
4 participants