Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics-operator): convert SLI names to valid K8s resource names #2125

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Sep 18, 2023

Closes #2098

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 1000f20
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6508416c3eb83800080672b9
😎 Deploy Preview https://deploy-preview-2125--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2125 (97ecf00) into main (d08df40) will increase coverage by 26.06%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2125       +/-   ##
===========================================
+ Coverage   58.26%   84.32%   +26.06%     
===========================================
  Files          35      150      +115     
  Lines        2389     9623     +7234     
===========================================
+ Hits         1392     8115     +6723     
- Misses        859     1224      +365     
- Partials      138      284      +146     
Files Changed Coverage Δ
metrics-operator/converter/common.go 100.00% <100.00%> (ø)
metrics-operator/converter/sli_converter.go 96.20% <100.00%> (ø)
metrics-operator/converter/slo_converter.go 94.71% <100.00%> (ø)

... and 127 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (-2.64%) ⬇️
component-tests 59.44% <ø> (+1.58%) ⬆️
lifecycle-operator 84.94% <ø> (?)
metrics-operator 87.15% <100.00%> (?)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl marked this pull request as ready for review September 19, 2023 06:40
@bacherfl bacherfl requested a review from a team as a code owner September 19, 2023 06:40
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 6da3276 into keptn:main Sep 19, 2023
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SLO/SLI converter: Handle SLI names that are not valid Kubernetes resource names
3 participants