-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lifecycle-operator): introduce functions for SchedulingGates functionality #2140
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lifecycle-operator/controllers/lifecycle/keptnworkloadinstance/controller_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptnworkloadinstance/controller_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/webhooks/pod_mutator/pod_mutating_webhook_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptnworkloadinstance/controller_test.go
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
+ Coverage 84.46% 84.54% +0.07%
==========================================
Files 151 152 +1
Lines 9723 9804 +81
==========================================
+ Hits 8213 8289 +76
- Misses 1224 1229 +5
Partials 286 286
... and 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ionality Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
I think we agreed that the gating should be done by a separate webhook that only checs creation and not update to avoid the ping pong issue, I do no thik this implementation follows the ticket #1458 |
lifecycle-operator/webhooks/pod_mutator/pod_mutating_webhook.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/webhooks/pod_mutator/pod_mutating_webhook.go
Outdated
Show resolved
Hide resolved
What I like about this current implementation is that the approach using the annotation that indicates that the scheduling gate has been removed makes it more explicit that the pod was actually handled by the lifecycle controller. So if this approach does not make the current webhook overly complex I would be fine with this solution as well |
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
lifecycle-operator/webhooks/pod_mutator/pod_mutating_webhook.go
Outdated
Show resolved
Hide resolved
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
lifecycle-operator/webhooks/pod_mutator/pod_mutating_webhook.go
Outdated
Show resolved
Hide resolved
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
lifecycle-operator/controllers/common/schedulinggateshandler.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/common/schedulinggateshandler.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/common/schedulinggateshandler_test.go
Outdated
Show resolved
Hide resolved
…est.go Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
lifecycle-operator/controllers/common/schedulinggateshandler.go
Outdated
Show resolved
Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
lifecycle-operator/webhooks/pod_mutator/pod_mutating_webhook.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/common/schedulinggateshandler.go
Outdated
Show resolved
Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed!
|
…ctionality (#2140) Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Changes
Follow-up
Part of #1458
Integration tests are green here #2149
Follow-up issue #2153