feat(lifecycle-operator): introduce functions for SchedulingGates functionality

[odubajDT]

Changes

• introduce functions which support scheduling gates usage
• unit tests
• renamed KLT leftover constants

Follow-up

• introduce integration tests
• adapt helm charts

Part of #1458

Integration tests are green here #2149

Follow-up issue #2153

[netlify]

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name	Link
🔨 Latest commit	681fbc5
🔍 Latest deploy log	https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/650c104b9aac17000a53878c
😎 Deploy Preview	https://deploy-preview-2140--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Merging #2140 (783e182) into main (47b756c) will increase coverage by 0.07%.
Report is 11 commits behind head on main.
The diff coverage is 87.50%.

❗ Current head 783e182 differs from pull request most recent head c0670fd. Consider uploading reports for the commit c0670fd to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2140      +/-   ##
==========================================
+ Coverage   84.46%   84.54%   +0.07%     
==========================================
  Files         151      152       +1     
  Lines        9723     9804      +81     
==========================================
+ Hits         8213     8289      +76     
- Misses       1224     1229       +5     
  Partials      286      286              

Files	Coverage Δ
...-operator/apis/lifecycle/v1alpha3/common/common.go	100.00% <100.00%> (ø)
...operator/apis/lifecycle/v1alpha3/keptnapp_types.go	93.33% <100.00%> (ø)
...tor/apis/lifecycle/v1alpha3/keptnworkload_types.go	93.93% <100.00%> (ø)
...rator/controllers/lifecycle/keptnapp/controller.go	63.15% <100.00%> (ø)
...ecycle/keptnappversion/reconcile_workloadsstate.go	93.75% <100.00%> (ø)
...lers/lifecycle/keptnworkloadinstance/controller.go	79.09% <100.00%> (+1.98%)	⬆️
...rator/webhooks/pod_mutator/pod_mutating_webhook.go	76.32% <100.00%> (+0.78%)	⬆️
...rator/controllers/common/schedulinggateshandler.go	81.03% <81.03%> (ø)

... and 6 files with indirect coverage changes

Flag	Coverage Δ
certificate-operator	65.91% <ø> (ø)
component-tests	58.24% <0.00%> (-0.11%)	⬇️
lifecycle-operator	85.02% <87.50%> (+0.08%)	⬆️
metrics-operator	87.40% <ø> (ø)
scheduler	32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[RealAnna]

I think we agreed that the gating should be done by a separate webhook that only checs creation and not update to avoid the ping pong issue, I do no thik this implementation follows the ticket #1458

[bacherfl]

I think we agreed that the gating should be done by a separate webhook that only checs creation and not update to avoid the ping pong issue, I do no thik this implementation follows the ticket #1458

What I like about this current implementation is that the approach using the annotation that indicates that the scheduling gate has been removed makes it more explicit that the pod was actually handled by the lifecycle controller. So if this approach does not make the current webhook overly complex I would be fine with this solution as well

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication