-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lifecycle-operator): remove hardcoded keptn namespace #2141
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: realanna <anna.reale@dynatrace.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2141 +/- ##
==========================================
+ Coverage 84.44% 84.47% +0.03%
==========================================
Files 150 151 +1
Lines 9634 9728 +94
==========================================
+ Hits 8135 8218 +83
- Misses 1217 1223 +6
- Partials 282 287 +5
... and 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
7618453
to
c4075eb
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
572c1f0
to
0cf7d74
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
lifecycle-operator/controllers/common/providers/keptnmetric/keptnmetric_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/controllers/lifecycle/keptntask/job_utils_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/test/component/appversion/appversion_suite_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/test/component/workloadinstance/workloadinstance_suite_test.go
Outdated
Show resolved
Hide resolved
as a follow up we could consider making the default namespace accessible via this config component: https://github.com/keptn/lifecycle-toolkit/blob/main/lifecycle-operator/controllers/common/config/config.go |
Did not even know we had that 😻 I think I will adapt it now |
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: realanna <anna.reale@dynatrace.com>
Closes #2139 removing hardcoded references to namespace