Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide unused KeptnEvaluationProvider from the crd docs #2146

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

RealAnna
Copy link
Contributor

KeptnEvaluationProviders are now KeptnMetricsProviders they stay in the API just to avoid a breaking change, we should not mention them in the docs to avoid generating confusion for the users.

Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna RealAnna requested review from a team as code owners September 21, 2023 08:03
@github-actions github-actions bot added documentation Improvements or additions to documentation ops labels Sep 21, 2023
@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit bf2df99
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/650bf8b8da89d90008eeb1e9
😎 Deploy Preview https://deploy-preview-2146--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #2146 (bf2df99) into main (2252b2d) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
+ Coverage   84.44%   84.52%   +0.08%     
==========================================
  Files         150      150              
  Lines        9634     9634              
==========================================
+ Hits         8135     8143       +8     
+ Misses       1217     1211       -6     
+ Partials      282      280       -2     

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 59.17% <ø> (+1.10%) ⬆️
lifecycle-operator 84.94% <ø> (ø)
metrics-operator 87.55% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RealAnna RealAnna merged commit d2743bf into main Sep 21, 2023
37 checks passed
@RealAnna RealAnna deleted the chore/hide_evaluation_provider_api_ref branch September 21, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants