-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics-operator): add support for user-friendly duration string for specifying time frame #2147
feat(metrics-operator): add support for user-friendly duration string for specifying time frame #2147
Conversation
…ame spec Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2147 +/- ##
==========================================
+ Coverage 84.52% 84.57% +0.04%
==========================================
Files 152 153 +1
Lines 9804 9881 +77
==========================================
+ Hits 8287 8357 +70
- Misses 1230 1237 +7
Partials 287 287
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
…ion-string-support # Conflicts: # metrics-operator/controllers/analysis/controller.go
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎃
… for specifying time frame (#2147) Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
… for specifying time frame (#2147) Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Closes #2129
This PR adds the feature described in #2129. The name of the new property is
spec.timeframe.recent
and it accepts a duration string as an input. As the name suggests, if this property is set to a valuex
, the timeframe for the analysis will be betweennow() - x
andnow()
. This timeframe is derived at the first time the Analysis is being reconciled. The derived timestamps are then stored in the status of the Analysis, otherwise the timeframe might shift over the course of multiple reconciliation loops.