Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lifecycle-operator): introduce metric showing readiness of operator #2152

Merged
merged 17 commits into from
Oct 3, 2023
Merged

feat(lifecycle-operator): introduce metric showing readiness of operator #2152

merged 17 commits into from
Oct 3, 2023

Conversation

geoffrey1330
Copy link
Member

fixes #1836

@geoffrey1330
keep
df50087 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
keep
26989d3 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
fd8436c 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330 geoffrey1330 requested a review from a team as a code owner September 22, 2023 10:09
@netlify
Copy link

netlify bot commented Sep 22, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit fd8436c
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/650d67f3cb4a8a0008689829
😎 Deploy Preview https://deploy-preview-2152--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
90a47a3 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited

Codecov Report

Merging #2152 (f056a95) into main (6566e7d) will increase coverage by 0.09%.
Report is 43 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2152      +/-   ##
==========================================
+ Coverage   84.51%   84.61%   +0.09%     
==========================================
  Files         151      154       +3     
  Lines        9728     9957     +229     
==========================================
+ Hits         8222     8425     +203     
- Misses       1220     1245      +25     
- Partials      286      287       +1

see 18 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 58.44% <ø> (+0.10%) ⬆️
lifecycle-operator 85.02% <ø> (+<0.01%) ⬆️
metrics-operator 87.55% <ø> (+0.15%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@geoffrey1330 geoffrey1330 changed the title Feat/1836/prepopulate keptn metrics lifecycle operator feat: add lifecycle_operator prepopulated keptn_ metrics to localhost:2222/metrics endpoint Sep 22, 2023
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
486c3be 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
b339a53 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
ee998d5 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
e608461 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
2fe56b1 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
ec29dc5 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
8733556 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
thisthat
thisthat reviewed Sep 26, 2023
View reviewed changes
lifecycle-operator/main.go Show resolved Hide resolved
lifecycle-operator/main.go Outdated Show resolved Hide resolved
geoffrey1330 and others added 3 commits September 26, 2023 13:58
@geoffrey1330 @thisthat
Update lifecycle-operator/main.go
58a7447 
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
0d1deaa 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
3b15ec2 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@mowies mowies changed the title feat: add lifecycle_operator prepopulated keptn_ metrics to localhost:2222/metrics endpoint feat: add lifecycle_operator prepopulated keptn_ metrics to metrics endpoint Sep 27, 2023
@odubajDT odubajDT changed the title feat: add lifecycle_operator prepopulated keptn_ metrics to metrics endpoint feat(lifecycle-operator): introduce metric showing readiness of operator Sep 28, 2023
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
87d5542 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
fd5d2bc 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Add prepopulated keptn_ metrics to localhost:2222/metrics endpoint
f056a95 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT
Copy link
Contributor

odubajDT commented Oct 3, 2023

@geoffrey1330 thank you for your contribution! :)

@odubajDT odubajDT merged commit c0e3f48 into keptn:main Oct 3, 2023
38 checks passed
This was referenced Oct 3, 2023
Merged
Merged
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
@geoffrey1330 @thisthat @StackScribe
feat(lifecycle-operator): introduce metric showing readiness of opera…
ec1fabb 
…tor (keptn#2152)

Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@odubajDT odubajDT odubajDT approved these changes

@thisthat thisthat Awaiting requested review from thisthat

Assignees
No one assigned
Labels
lifecycle-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

localhost:2222/metrics prepopulate with some keptn_ metrics
4 participants
@geoffrey1330 @odubajDT @thisthat @RealAnna