-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add first iteration of analysis documentation #2167
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2167 +/- ##
==========================================
+ Coverage 84.52% 84.54% +0.01%
==========================================
Files 152 153 +1
Lines 9804 9881 +77
==========================================
+ Hits 8287 8354 +67
- Misses 1230 1238 +8
- Partials 287 289 +2 see 5 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Would it makes sense to link the SLO and SLI conversion docs to this? When we are referring to Keptn v1, some users might find it helpful how to convert their manifests |
sure, where is it? |
https://github.com/keptn/lifecycle-toolkit/tree/main/metrics-operator/converter |
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is an excellent start to the docs and gives me enough information to take over, I think. I started nitting at your prose, the source code line lengths, etc but that is silly! You don't need to be bothered by such things! Let's get this so it passes markdownlint and get it merged. I can take it from here. |
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
905805f
to
66080d6
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes #1824
checkout preview here https://deploy-preview-2167--keptn-lifecycle-toolkit.netlify.app/docs/implementing/slo/