Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics-operator): add missing AnalysisDefinition validation webhook to helm templates #2173

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix(metrics-operator): add missing AnalysisDefinition validation webhook to helm templates #2173

merged 1 commit into from
Sep 27, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Sep 26, 2023

Changes

  • add missing AnalysisDefinition validation webhook to helm templates
  • introduce integration test to verify validation webhook works
  • move analysis integration tests into a separate folder
  • fix error message in validating webhook

Fixes #2165

@github-actions github-actions bot added the helm label Sep 26, 2023
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit d1a737e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65129518857a26000878cfcb
😎 Deploy Preview https://deploy-preview-2173--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2173 (e03a075) into main (5efa650) will increase coverage by 0.07%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
+ Coverage   84.47%   84.55%   +0.07%     
==========================================
  Files         151      152       +1     
  Lines        9728     9804      +76     
==========================================
+ Hits         8218     8290      +72     
- Misses       1223     1228       +5     
+ Partials      287      286       -1     

see 5 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 58.85% <ø> (+0.79%) ⬆️
lifecycle-operator 85.02% <ø> (+<0.01%) ⬆️
metrics-operator 87.40% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review September 26, 2023 09:20
@odubajDT odubajDT requested a review from a team as a code owner September 26, 2023 09:20
…ook to helm templates

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit 98097e6 into keptn:main Sep 27, 2023
33 checks passed
RealAnna pushed a commit that referenced this pull request Sep 27, 2023
…ook to helm templates (#2173)

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validating Webhook for AnalysisDefinition is missing in Helm chart
3 participants