Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test and lint cmd to makefiles #2176

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

prakrit55
Copy link
Member

fixes: #1935

  • add golangci-lint cmd in subfiles as well as in root makefile
  • add test cmd for in subfiles as well as in root makefile

Signed-off-by: Griffin <prakritimandal611@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 75ba416
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65130af36d398f0008cc4bb3
😎 Deploy Preview https://deploy-preview-2176--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2176 (75ba416) into main (643ae4e) will decrease coverage by 0.10%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
- Coverage   84.57%   84.48%   -0.10%     
==========================================
  Files         152      152              
  Lines        9804     9804              
==========================================
- Hits         8292     8283       -9     
- Misses       1226     1233       +7     
- Partials      286      288       +2     

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 57.82% <ø> (-0.42%) ⬇️
lifecycle-operator 85.02% <ø> (ø)
metrics-operator 87.40% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT
Copy link
Contributor

Hello @prakrit55 do you need any support here or is everything clear? Thank you

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @prakrit55 😃

@prakrit55
Copy link
Member Author

Hello @prakrit55 do you need any support here or is everything clear? Thank you

Hey @odubajDT, I missed your message. I was about to ask since the golangci-lint install command is placed in the root makefile, shouldn't I have placed it in the other files too ?

@odubajDT
Copy link
Contributor

Hello @prakrit55 do you need any support here or is everything clear? Thank you

Hey @odubajDT, I missed your message. I was about to ask since the golangci-lint install command is placed in the root makefile, shouldn't I have placed it in the other files too ?

It's ok as it is. Thank you for contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test and go lint cmds to makefiles
3 participants