feat(metrics-operator): implement interface for analysis value retrieval in DQL provider #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DQL provider Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2194 +/- ##
==========================================
+ Coverage 84.55% 84.61% +0.06%
==========================================
Files 154 154
Lines 9918 9957 +39
==========================================
+ Hits 8386 8425 +39
+ Misses 1246 1245 -1
- Partials 286 287 +1
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
odubajDT
reviewed
Sep 29, 2023
metrics-operator/controllers/common/providers/dynatrace/dynatrace_dql.go
Show resolved
Hide resolved
RealAnna
approved these changes
Sep 29, 2023
odubajDT
approved these changes
Sep 29, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
StackScribe
pushed a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Oct 13, 2023
…val in DQL provider (keptn#2194) Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2151