Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lifecycle-operator): automatically decide for scheduler installation based on k8s version #2212

Merged
merged 31 commits into from
Oct 3, 2023
Merged

feat(lifecycle-operator): automatically decide for scheduler installation based on k8s version #2212

merged 31 commits into from
Oct 3, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Oct 2, 2023 •
edited

closes #1460

  1. The scheduling feature needs to be enabled and the k8s minor version needs to be more than 26 for the gates to be enabled
  2. docs are updated to explain both gates and scheduler

@RealAnna
feat: added condition on k8s version for scheduling gates
76d975d 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: added condition on k8s version for scheduling gates
3d4e737 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna RealAnna requested a review from a team as a code owner October 2, 2023 09:57
@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit fc9f4b4
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/651ac374ff7f68000996980f
😎 Deploy Preview https://deploy-preview-2212--keptn-lifecycle-toolkit.netlify.app/docs/architecture/components/scheduler
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited

Codecov Report

Merging #2212 (0187acd) into main (9f0853f) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
- Coverage   84.61%   84.57%   -0.05%     
==========================================
  Files         154      154              
  Lines        9957     9957              
==========================================
- Hits         8425     8421       -4     
- Misses       1245     1248       +3     
- Partials      287      288       +1

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 57.82% <ø> (-0.28%) ⬇️
lifecycle-operator 85.02% <ø> (ø)
metrics-operator 87.55% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna
feat: added scheduling gates doc
c8d6a5b 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: changed ref in docs
7a4c95c 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna RealAnna requested a review from a team as a code owner October 2, 2023 10:22
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 2, 2023
@RealAnna
feat: changed ref in docs
fba7c19 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: linted
822a786 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
Copy link
Contributor Author

RealAnna commented Oct 2, 2023

values and README are currently missing due to ☔ helm chart, so please ignore the failing Html and Markdown checks

@RealAnna
feat: linted
c640426 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: linted
445a5c9 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: linted
95b92ba 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: linted
eed5f91 
Signed-off-by: realanna <anna.reale@dynatrace.com>
thisthat
thisthat reviewed Oct 2, 2023
View reviewed changes
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
docs/content/en/docs/architecture/components/scheduler/_index.md Outdated Show resolved Hide resolved
RealAnna and others added 3 commits October 2, 2023 13:07
@RealAnna
feat: linted
2b3948e 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
feat: linted
badc507 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna @thisthat
Apply suggestions from code review
2d0c26e 
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@mowies mowies changed the title feat(lifecycle-operator): automatic decide for scheduler installation based on k8s version feat(lifecycle-operator): automatically decide for scheduler installation based on k8s version Oct 2, 2023
@RealAnna
ffix according to review
fc9f4b4 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
ffix k8s version
711711a 
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna and others added 4 commits October 2, 2023 15:38
@RealAnna
embed yaml
a4dd16c 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna @mowies
Update docs/content/en/docs/architecture/components/scheduler/_index.md
2d91a2b 
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
embed yaml
18b42a0 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
Merge branch 'feat/automatic_scheduler_installation' of github.com:ke…
4568da2 
…ptn/lifecycle-toolkit into feat/automatic_scheduler_installation
StackScribe
StackScribe reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I'd like to review again when netlify works so I can see what the embedded text looks like.

RealAnna and others added 6 commits October 3, 2023 07:42
@RealAnna
fix typos
be17021 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix path
399d976 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna @StackScribe
Update docs/content/en/docs/architecture/components/scheduler/_index.md
67c18a9 
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna @StackScribe
Apply suggestions from code review
9fa2703 
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@RealAnna
add sentence on api
ef1a883 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
Merge branch 'feat/automatic_scheduler_installation' of github.com:ke…
0722e69 
…ptn/lifecycle-toolkit into feat/automatic_scheduler_installation
@keptn keptn deleted a comment from RealAnna Oct 3, 2023
RealAnna and others added 3 commits October 3, 2023 08:47
@RealAnna
add sentence on api
add1ed3 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
removed bad cascade
3fa6967 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna @odubajDT
Update docs/content/en/docs/architecture/components/scheduler/_index.md
0187acd 
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 25976ea into main Oct 3, 2023
31 of 38 checks passed
@RealAnna RealAnna deleted the feat/automatic_scheduler_installation branch October 3, 2023 09:21
This was referenced Oct 3, 2023
Merged
Merged
@RealAnna RealAnna mentioned this pull request Oct 12, 2023
Closed
@mowies mowies linked an issue Oct 12, 2023 that may be closed by this pull request
Switch scheduling behaviour with helm value #1601
Closed
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
@RealAnna @thisthat
@mowies @StackScribe @odubajDT
feat(lifecycle-operator): automatically decide for scheduler installa…
e775657 
…tion based on k8s version (keptn#2212)

Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Co-authored-by: Giovanni Liva <giovanni.liva@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat left review comments

@mowies mowies mowies left review comments

@StackScribe StackScribe StackScribe approved these changes

@odubajDT odubajDT odubajDT approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation lifecycle-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch scheduling behaviour with helm value Mark Scheduler as deprecated
5 participants
@RealAnna @thisthat @StackScribe @mowies @odubajDT