Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create new Keptn umbrella Helm chart #2214

Merged
merged 29 commits into from
Oct 4, 2023
Merged

feat: create new Keptn umbrella Helm chart #2214

merged 29 commits into from
Oct 4, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Oct 2, 2023 •
edited

Fixes #2184

@netlify
Copy link

netlify bot commented Oct 2, 2023 •
edited

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit cc9ee7f
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/651bfc8c6a78ef000859eaf1
😎 Deploy Preview https://deploy-preview-2214--keptn-lifecycle-toolkit.netlify.app/docs/architecture/components/scheduler
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited

Codecov Report

Merging #2214 (f27b1d8) into main (25976ea) will decrease coverage by 0.49%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
- Coverage   85.19%   84.70%   -0.49%     
==========================================
  Files          96      154      +58     
  Lines        6462     9957    +3495     
==========================================
+ Hits         5505     8434    +2929     
- Misses        799     1238     +439     
- Partials      158      285     +127

see 61 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (?)
component-tests 59.27% <ø> (+1.44%) ⬆️
lifecycle-operator 85.02% <ø> (ø)
metrics-operator 87.55% <ø> (?)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 2, 2023
@RealAnna
Copy link
Contributor

RealAnna commented Oct 3, 2023

we can fix the helm chart ref in the docs now so we fix the pipelines 🐈

StackScribe
StackScribe previously approved these changes Oct 3, 2023
View reviewed changes
mowies and others added 14 commits October 3, 2023 13:28
@mowies
add new umbrella/wrapper chart
87c0327 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
minor updates to install action
1860d6f 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix lifecycle and metrics operator chart versions
1390fc3 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix lifecycle operator and scheduler wrong values references
0299a75 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
adapt install action
6f1c4fa 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
add helm deps udpate and build
3ccff30 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
use correct folder
ce68b68 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
generate helm docs for keptn chart
7297630 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix yaml linting
22063d1 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix MD linter
32c86ff 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix docs links
d03cdb0 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@RealAnna @mowies
fix: correct helm chart version
647eb53 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna @mowies
fix: correct helm chart version
2fba790 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@mowies
fix cert manager SA labels
40edfa8 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies and others added 4 commits October 3, 2023 13:35
@mowies
remove trailing whitespace
cc9ee7f 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@RealAnna
fix: correct helm chart version
89f3a34 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@mowies
fix chart problems in subcharts
a2bb986 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix helm test setup
7000095 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
RealAnna
RealAnna previously approved these changes Oct 3, 2023
View reviewed changes
bacherfl
bacherfl previously approved these changes Oct 3, 2023
View reviewed changes
StackScribe
StackScribe previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor edits to the prose for your consideration.

odubajDT
odubajDT previously approved these changes Oct 4, 2023
View reviewed changes
thisthat
thisthat previously approved these changes Oct 4, 2023
View reviewed changes
@RealAnna RealAnna mentioned this pull request Oct 4, 2023
Closed
3 tasks
@mowies
update umbrella chart with aliases
a927139 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
update helpers manually
d8f8b86 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
update all chart helpers to use kebabcase for the chart name and k8s …
6416323 
…name label

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
update helm test result
4f78c4b 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix integration test action
f27b1d8 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit 41bd47b into keptn:main Oct 4, 2023
37 of 39 checks passed
@mowies mowies deleted the keptn-umbrella-chart branch October 4, 2023 12:16
This was referenced Oct 4, 2023
Merged
Merged
Merged
Merged
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
@mowies @RealAnna @StackScribe
feat: create new Keptn umbrella Helm chart (keptn#2214)
ffe54bc 
Co-authored-by: realanna <anna.reale@dynatrace.com>
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat approved these changes

@RealAnna RealAnna RealAnna approved these changes

@bacherfl bacherfl bacherfl left review comments

@StackScribe StackScribe StackScribe left review comments

@odubajDT odubajDT odubajDT left review comments

Assignees
No one assigned
Labels
cert-manager documentation Improvements or additions to documentation lifecycle-operator metrics-operator ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create umbrella Keptn helm chart
6 participants
@mowies @RealAnna @thisthat @bacherfl @StackScribe @odubajDT