Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change klt to keptn for annotations and certs #2229

Merged
merged 5 commits into from
Oct 5, 2023
Merged

fix: change klt to keptn for annotations and certs #2229

merged 5 commits into from
Oct 5, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Oct 4, 2023 •
edited

closes #2211
closes #2015

@RealAnna RealAnna requested a review from a team as a code owner October 4, 2023 13:22
@netlify
Copy link

netlify bot commented Oct 4, 2023 •
edited

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 27f1773
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/651e5720bf282800089797c3
😎 Deploy Preview https://deploy-preview-2229--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RealAnna RealAnna requested a review from a team as a code owner October 4, 2023 13:26
@github-actions github-actions bot added documentation Improvements or additions to documentation metrics-operator cert-manager labels Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited

Codecov Report

Merging #2229 (27f1773) into main (f11fdb9) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
+ Coverage   84.57%   84.65%   +0.08%     
==========================================
  Files         154      154              
  Lines        9957     9960       +3     
==========================================
+ Hits         8421     8432      +11     
+ Misses       1248     1242       -6     
+ Partials      288      286       -2
Files Coverage Δ
...okcontroller/keptnwebhookcertificate_controller.go 45.39% <ø> (ø)
...rs/lifecycle/keptnappcreationrequest/controller.go 78.21% <100.00%> (+0.37%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
lifecycle-operator 85.03% <100.00%> (+<0.01%) ⬆️
metrics-operator 87.55% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna RealAnna changed the title fix: change managed annotation from klt to keptn fix: change klt to keptn for annotations and certs Oct 4, 2023
@RealAnna RealAnna marked this pull request as draft October 4, 2023 14:52
@RealAnna RealAnna marked this pull request as ready for review October 4, 2023 15:03
@RealAnna
fix: change annotation from klt to keptn
2d4f7af 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: docs
2050977 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: change klt-certs
5cb941b 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: controller resourceNames
b414b64 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@RealAnna
fix: update dependancies
27f1773 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 608a75e into main Oct 5, 2023
42 checks passed
@RealAnna RealAnna deleted the chore/add_keptn_annotation branch October 5, 2023 06:51
This was referenced Oct 5, 2023
Merged
Merged
Merged
Merged
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
@RealAnna @StackScribe
fix: change klt to keptn for annotations and certs (keptn#2229)
9d1a9c5 
Signed-off-by: realanna <anna.reale@dynatrace.com>
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl approved these changes

@odubajDT odubajDT odubajDT approved these changes

Assignees
No one assigned
Labels
cert-manager documentation Improvements or additions to documentation lifecycle-operator metrics-operator
Projects
None yet
Milestone
No milestone
3 participants
@RealAnna @bacherfl @odubajDT