Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lifecycle-operator): introduce option to enable lifecycle orchestration only for specific namespaces #2244

Merged
merged 20 commits into from
Oct 11, 2023
Merged

feat(lifecycle-operator): introduce option to enable lifecycle orchestration only for specific namespaces #2244

merged 20 commits into from
Oct 11, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Oct 6, 2023 •
edited

Changes

  • adapt helm charts to allow mutating webhook only for certain namespaces
  • adapt installation action to be able to test the feature
  • introduce integration tests
  • update docs
  • document changes

Fixes: #2090

@netlify
Copy link

netlify bot commented Oct 6, 2023

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit e9fb596
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/651fcfff4f464c0008d7d951
😎 Deploy Preview https://deploy-preview-2244--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited

Codecov Report

Merging #2244 (3507f0e) into main (a05a915) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 3507f0e differs from pull request most recent head 68f41cf. Consider uploading reports for the commit 68f41cf to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2244      +/-   ##
==========================================
- Coverage   84.63%   84.61%   -0.03%     
==========================================
  Files         154      154              
  Lines        9960     9960              
==========================================
- Hits         8430     8428       -2     
- Misses       1244     1245       +1     
- Partials      286      287       +1

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 57.89% <ø> (-0.35%) ⬇️
lifecycle-operator 85.03% <ø> (ø)
metrics-operator 87.55% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added documentation Improvements or additions to documentation ops labels Oct 6, 2023
@odubajDT odubajDT changed the title feat(lifecycle-operator): introduce option to enable MutatingWebhookConfiguration only for specific namespaces feat(lifecycle-operator): introduce option to enable MutatingWebhook for specific namespaces Oct 9, 2023
@odubajDT odubajDT marked this pull request as ready for review October 9, 2023 07:10
@odubajDT odubajDT requested a review from a team as a code owner October 9, 2023 07:10
bacherfl
bacherfl reviewed Oct 9, 2023
View reviewed changes
README.md Show resolved Hide resolved
StackScribe
StackScribe reviewed Oct 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Oct 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Oct 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Oct 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
StackScribe
StackScribe reviewed Oct 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
odubajDT
odubajDT commented Oct 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
RealAnna
RealAnna reviewed Oct 10, 2023
View reviewed changes
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
odubajDT and others added 11 commits October 10, 2023 12:37
@odubajDT
feat(lifecycle-operator): introduce option to enable MutatingWebhookC…
35fe9c9 
…onfiguration only for specific namespaces

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
document changes
8a2afcf 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
adapt pipelines
85455ec 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
add new tests into pipeline
748b022 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
create folder for tests
f305143 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
introduce integration tests
eb496d0 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix instalation action
404f00d 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
document instalation steps
ee46826 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
pr review
525f3f4 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT @StackScribe
Apply suggestions from code review
c94d5c1 
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@odubajDT
Update README.md
18a2c95 
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@odubajDT
polish
40b2692 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix
af8dd00 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
polish CI
7a2c8c2 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix
25b4a6e 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix
05844f7 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix
da0ae09 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix
a925eb6 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix
3507f0e 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT
fix
68f41cf 
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT changed the title feat(lifecycle-operator): introduce option to enable MutatingWebhook for specific namespaces feat(lifecycle-operator): introduce option to enable lifecycle orchestration only for specific namespaces Oct 11, 2023
@odubajDT odubajDT merged commit 12caf03 into keptn:main Oct 11, 2023
41 checks passed
This was referenced Oct 11, 2023
Merged
Merged
StackScribe added a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
@odubajDT @StackScribe
feat(lifecycle-operator): introduce option to enable lifecycle orches…
b8b0e7e 
…tration only for specific namespaces (keptn#2244)

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisthat thisthat thisthat left review comments

@StackScribe StackScribe StackScribe left review comments

@bacherfl bacherfl bacherfl approved these changes

@RealAnna RealAnna RealAnna approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart: Add option to enable MutatingWebhookConfiguration only for specific namespaces
5 participants
@odubajDT @thisthat @bacherfl @StackScribe @RealAnna