-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lifecycle-operator): introduce v1alpha4 API version for KeptnWorkloadInstance #2250
Conversation
…kloadInstance Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2250 +/- ##
==========================================
+ Coverage 84.63% 84.79% +0.15%
==========================================
Files 154 155 +1
Lines 9960 10182 +222
==========================================
+ Hits 8430 8634 +204
- Misses 1244 1259 +15
- Partials 286 289 +3
... and 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
lifecycle-operator/apis/lifecycle/v1alpha4/keptnworkloadcersion_types_test.go
Outdated
Show resolved
Hide resolved
lifecycle-operator/apis/lifecycle/v1alpha4/keptnworkloadcersion_types_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
lifecycle-operator/apis/lifecycle/v1alpha4/keptnworkloadversion_types.go
Show resolved
Hide resolved
lifecycle-operator/config/samples/lifecycle_v1alpha4_keptnworkloadversion.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one optional suggestion, other than that lgtm
…loadversion.yaml Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed!
|
…kloadInstance (keptn#2250) Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com> Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Part of: #66
Changes
Follow-up