Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): introduce v1alpha4 API version for KeptnWorkloadInstance #2250

Merged
merged 12 commits into from
Oct 11, 2023
Merged

feat(lifecycle-operator): introduce v1alpha4 API version for KeptnWorkloadInstance #2250

merged 12 commits into from
Oct 11, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Oct 9, 2023

Part of: #66

Changes

  • introduce v1alpha4 API into lifecycle group
  • adapt manifests
  • adapt helm charts
  • regenerate docs + resolve problems
  • regenerate helm chart tests
  • introduce integration test

Follow-up

  • adapt controllers to use WorkloadVersion
  • adapt tests

…kloadInstance

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation lifecycle-operator labels Oct 9, 2023
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 7dd0ba8
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65252f4eade204000875f990
😎 Deploy Preview https://deploy-preview-2250--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/lifecycle/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2250 (7dd0ba8) into main (61ca8b7) will increase coverage by 0.15%.
Report is 4 commits behind head on main.
The diff coverage is 95.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
+ Coverage   84.63%   84.79%   +0.15%     
==========================================
  Files         154      155       +1     
  Lines        9960    10182     +222     
==========================================
+ Hits         8430     8634     +204     
- Misses       1244     1259      +15     
- Partials      286      289       +3     
Files Coverage Δ
...tor/apis/lifecycle/v1alpha3/keptnworkload_types.go 93.93% <ø> (ø)
...s/lifecycle/v1alpha4/keptnworkloadversion_types.go 95.49% <95.49%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 65.91% <ø> (ø)
component-tests 58.24% <ø> (ø)
lifecycle-operator 85.40% <95.49%> (+0.37%) ⬆️
metrics-operator 87.55% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@github-actions github-actions bot added the ops label Oct 9, 2023
@odubajDT odubajDT marked this pull request as ready for review October 9, 2023 12:08
@odubajDT odubajDT requested review from a team as code owners October 9, 2023 12:08
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
bacherfl
bacherfl previously approved these changes Oct 9, 2023
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one optional suggestion, other than that lgtm

…loadversion.yaml

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
bacherfl
bacherfl previously approved these changes Oct 9, 2023
odubajDT and others added 2 commits October 10, 2023 12:36
Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@odubajDT odubajDT merged commit d95dc10 into keptn:main Oct 11, 2023
45 checks passed
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
…kloadInstance (keptn#2250)

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants