Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lifecycle-operator): improve logging #2253

Merged
merged 26 commits into from
Oct 12, 2023
Merged

chore(lifecycle-operator): improve logging #2253

merged 26 commits into from
Oct 12, 2023

Conversation

geoffrey1330
Copy link
Member

@geoffrey1330 geoffrey1330 commented Oct 9, 2023 •
edited by bacherfl

fixes #1880

@geoffrey1330
keep
c7d5540 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
keep
7790c0a 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
a4f505b 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330 geoffrey1330 requested a review from a team as a code owner October 9, 2023 12:27
@netlify
Copy link

netlify bot commented Oct 9, 2023 •
edited

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit cdd42a7
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65265d7dac656200089002f1
😎 Deploy Preview https://deploy-preview-2253--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited

Codecov Report

Merging #2253 (4009e7e) into main (c1166ff) will increase coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is 89.65%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2253      +/-   ##
==========================================
+ Coverage   85.57%   85.62%   +0.05%     
==========================================
  Files         159      159              
  Lines       10226    10236      +10     
==========================================
+ Hits         8751     8765      +14     
+ Misses       1200     1197       -3     
+ Partials      275      274       -1
Files Coverage Δ
...cle-operator/controllers/common/helperfunctions.go 98.63% <100.00%> (+0.10%) ⬆️
...rator/controllers/lifecycle/keptnapp/controller.go 63.47% <100.00%> (+0.32%) ⬆️
...ontrollers/lifecycle/keptnappversion/controller.go 82.30% <100.00%> (ø)
...ollers/lifecycle/keptntaskdefinition/controller.go 89.36% <100.00%> (+8.92%) ⬆️
.../controllers/lifecycle/keptnworkload/controller.go 65.88% <100.00%> (+0.40%) ⬆️
...lers/lifecycle/keptnworkloadinstance/controller.go 79.63% <100.00%> (+0.09%) ⬆️
...ontrollers/lifecycle/keptnevaluation/controller.go 76.12% <80.00%> (ø)
...ator/controllers/lifecycle/keptntask/controller.go 56.33% <60.00%> (+0.62%) ⬆️
Flag Coverage Δ
certificate-operator 67.19% <ø> (ø)
component-tests 59.06% <87.50%> (+0.62%) ⬆️
lifecycle-operator 86.51% <66.66%> (+<0.01%) ⬆️
metrics-operator 87.55% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@geoffrey1330
Improve logging in lifecycle controller using relevant context
e25a8e4 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
8223552 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
d153ce6 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
e52b3f8 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
e8814b0 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
bf1b5ef 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
0eeb24b 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
306bf3b 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
cec7f65 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@RealAnna
Copy link
Contributor

@geoffrey1330 let's try to rebase main and rerun the tests

@geoffrey1330
Copy link
Member Author

@geoffrey1330 let's try to rebase main and rerun the tests

Alright

geoffrey1330 and others added 2 commits October 11, 2023 14:44
@geoffrey1330 @bacherfl
Update lifecycle-operator/controllers/lifecycle/keptnevaluation/contr…
d6d0168 
…oller.go

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
d3c4d66 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Copy link
Member Author

Hi @bacherfl All checks have passed successfully.
could you please review.

@geoffrey1330 @bacherfl
Update lifecycle-operator/controllers/lifecycle/keptnevaluation/contr…
e6429ab 
…oller.go

Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
geoffrey1330 and others added 4 commits October 12, 2023 09:03
@geoffrey1330 @bacherfl
Update lifecycle-operator/controllers/common/helperfunctions.go
838e3da 
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
a5d1f4a 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
568f50c 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
9b8f0ab 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
geoffrey1330 and others added 4 commits October 12, 2023 11:32
@geoffrey1330 @odubajDT
Update lifecycle-operator/controllers/common/helperfunctions.go
53f3acd 
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
@geoffrey1330 @odubajDT
Update lifecycle-operator/controllers/common/helperfunctions_test.go
90fe37e 
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
45eee69 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Improve logging in lifecycle controller using relevant context
4009e7e 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl changed the title feat: improve logging controller lifecycle chore(lifecycle-operator): improve logging Oct 12, 2023
@bacherfl bacherfl merged commit 8dd3394 into keptn:main Oct 12, 2023
45 checks passed
@keptn-bot keptn-bot mentioned this pull request Oct 12, 2023
Merged
@bacherfl bacherfl mentioned this pull request Oct 12, 2023
Closed
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
@geoffrey1330 @bacherfl
@odubajDT @StackScribe
chore(lifecycle-operator): improve logging (keptn#2253)
49d7b89 
Signed-off-by: Geoffrey Israel <israelgeoffrey13@gmail.com>
Co-authored-by: Florian Bacher <florian.bacher@dynatrace.com>
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna left review comments

@bacherfl bacherfl bacherfl approved these changes

@odubajDT odubajDT odubajDT approved these changes

Assignees
No one assigned
Labels
lifecycle-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve logging in Controllers by adding relevant context
4 participants
@geoffrey1330 @RealAnna @bacherfl @odubajDT