fix(cert-manager): exclude CRDs from cache to avoid excessive memory usage #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usage Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
===========================================
- Coverage 84.61% 74.01% -10.61%
===========================================
Files 154 80 -74
Lines 9960 5226 -4734
===========================================
- Hits 8428 3868 -4560
+ Misses 1245 1142 -103
+ Partials 287 216 -71
... and 86 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
…nto fix/cert-resource-consumption
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Oct 10, 2023
thisthat
approved these changes
Oct 11, 2023
thisthat
approved these changes
Oct 11, 2023
StackScribe
pushed a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Oct 13, 2023
…usage (keptn#2258) Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2257
This PR disables the cache for CustomResourceDefinitions in the certificate-operator. The reason for that change is to prevent OOMKills in the certificate operator, as when caching is enabled for a certain resource, all existing objects of that resource are retrieved initially and stored in an internal cache. This can be a problem especially for CRDs, which can be particularly large. Also, this means that the memory usage of the operator will be directly affected by the number of CustomResourceDefinitions in the cluster. In my case this caching behavior this lead to either the operator running into OOMKills, or taking over a minute for handling the retrieval of CRDs (if the memory limit has been increased).