Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics-operator): improve logging #2269

Merged

Conversation

geoffrey1330
Copy link
Member

fixes #1880

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 703fd6c
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/652d2355fc79780008fccf50
😎 Deploy Preview https://deploy-preview-2269--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #2269 (703fd6c) into main (91dd45e) will decrease coverage by 0.05%.
The diff coverage is 73.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
- Coverage   85.69%   85.64%   -0.05%     
==========================================
  Files         159      160       +1     
  Lines       10227    10234       +7     
==========================================
+ Hits         8764     8765       +1     
- Misses       1189     1193       +4     
- Partials      274      276       +2     
Files Coverage Δ
metrics-operator/controllers/common/common.go 100.00% <100.00%> (ø)
...etrics-operator/controllers/analysis/controller.go 84.87% <80.00%> (+0.12%) ⬆️
metrics-operator/controllers/metrics/controller.go 79.20% <55.55%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.19% <ø> (ø)
component-tests 59.05% <ø> (-0.41%) ⬇️
lifecycle-operator 85.45% <ø> (ø)
metrics-operator 87.58% <73.68%> (+0.03%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Copy link
Member Author

Hi @bacherfl could you please review.
cc @odubajDT

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 2e35273 into keptn:main Oct 16, 2023
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging in Controllers by adding relevant context
3 participants