Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upgrade Keptn to Helm from a manifest installation #2270

Merged
merged 8 commits into from
Oct 18, 2023
Merged

docs: upgrade Keptn to Helm from a manifest installation #2270

merged 8 commits into from
Oct 18, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Oct 12, 2023

Fixes: #1176

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 12, 2023
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit a9e660f
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/652e4bc6a4a07f00089684bc
😎 Deploy Preview https://deploy-preview-2270--keptn-lifecycle-toolkit.netlify.app/docs/install/upgrade
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@odubajDT odubajDT marked this pull request as ready for review October 12, 2023 13:28
@odubajDT odubajDT requested review from a team as code owners October 12, 2023 13:28
@thisthat thisthat changed the title docs: upgrade Keptn installed via manifests using Helm docs: upgrade Keptn to Helm from a manifest installation Oct 13, 2023
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best way to support this would be providing a CRD-less manifest for each old installation. This way it could simply be: kubectl delete -f keptn-vX.Y.Z-crdless.yaml; helm install ...
This way the CRD definition will live and the CR won't be lost, but all the rest is cleaned up. I don't know, however, how Helm handles the CRD again since are already there 🤔

odubajDT and others added 7 commits October 13, 2023 10:30
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Co-authored-by: Meg McRoberts <meg.mcroberts@dynatrace.com>
Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@RealAnna
Copy link
Contributor

I think the best way to support this would be providing a CRD-less manifest for each old installation. This way it could simply be: kubectl delete -f keptn-vX.Y.Z-crdless.yaml; helm install ... This way the CRD definition will live and the CR won't be lost, but all the rest is cleaned up. I don't know, however, how Helm handles the CRD again since are already there 🤔

If we provide a CRD-less chart than users need to update CRDs manually via manifest, and they are stuck forever in this 😢

StackScribe
StackScribe previously approved these changes Oct 16, 2023
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that we should pull the backup info into its own page in the "Operate" section then link to that from here. But let's merge this PR first then I can do that in a separate PR.

Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 39 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@StackScribe StackScribe merged commit cfb7641 into keptn:main Oct 18, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use Helm to upgrade instance installed from manifest
4 participants