Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cert-manager): improve logging #2279

Merged

Conversation

geoffrey1330
Copy link
Member

fixes #1880

Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330 geoffrey1330 requested a review from a team as a code owner October 16, 2023 12:45
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit ba18cc9
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/652e55f4b493d70008124810
😎 Deploy Preview https://deploy-preview-2279--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@geoffrey1330 geoffrey1330 changed the title chore(klt-cert-manager): improve logging chore(cert-manager): improve logging Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2279 (ba18cc9) into main (2e35273) will decrease coverage by 0.73%.
Report is 1 commits behind head on main.
The diff coverage is 69.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
- Coverage   85.66%   84.93%   -0.73%     
==========================================
  Files         160      114      -46     
  Lines       10234     7403    -2831     
==========================================
- Hits         8767     6288    -2479     
+ Misses       1192      920     -272     
+ Partials      275      195      -80     
Files Coverage Δ
klt-cert-manager/pkg/common/common.go 100.00% <100.00%> (ø)
...okcontroller/keptnwebhookcertificate_controller.go 53.89% <50.00%> (ø)

... and 47 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <69.23%> (+0.23%) ⬆️
component-tests 59.18% <ø> (ø)
lifecycle-operator 85.45% <ø> (ø)
metrics-operator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@geoffrey1330
Copy link
Member Author

@bacherfl @RealAnna could you please review my PR.

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! :)

@odubajDT odubajDT merged commit 859459d into keptn:main Oct 17, 2023
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging in Controllers by adding relevant context
3 participants