-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move helm docs into values files #2281
Conversation
Signed-off-by: Griffin <prakritimandal611@gmail.com>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please put each docs line right above the corresponding helm values?
otherwise, this looks very good already!
if there are @skip
statements for a for children of a helm value, please put them above the parent value
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
===========================================
- Coverage 85.68% 58.90% -26.79%
===========================================
Files 161 35 -126
Lines 10246 2421 -7825
===========================================
- Hits 8779 1426 -7353
+ Misses 1192 862 -330
+ Partials 275 133 -142 see 141 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Griffin <prakritimandal611@gmail.com>
hey @mowies, could you review it once, if we need any more changes over here |
hey @mowies, should I generate the readme and push it |
@prakrit55 yes! checking the PR now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please push the new generated readme's as well
Signed-off-by: Griffin <prakritimandal611@gmail.com>
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the contribution!
fixes: #2196
doc.yml
files are all deleted